mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70755: Added tests for the V0 UPDATE_FRAMEWORK scheduler call.
Date Wed, 12 Jun 2019 16:33:08 GMT


> On June 11, 2019, 7:36 p.m., Benjamin Mahler wrote:
> > src/tests/master/update_framework_tests.cpp
> > Lines 664-666 (patched)
> > <https://reviews.apache.org/r/70755/diff/2/?file=2147660#file2147660line664>
> >
> >     Same race as the v1 tests, this needs to be before StartSlave, otherwise the
agent might show up in the initial SUBSCRIBE state

Yeah, I've fixed it in `UpdateFrameworkTest.OffersOnAddingRole` and somehow forgot about three
other places :(


> On June 11, 2019, 7:36 p.m., Benjamin Mahler wrote:
> > src/tests/master/update_framework_tests.cpp
> > Lines 690-691 (patched)
> > <https://reviews.apache.org/r/70755/diff/2/?file=2147660#file2147660line690>
> >
> >     V0 scheduler event? I guess you mean the master acknowledging the update? We
may never add that, so probably we should just remove the TODO

Yes, exactly. Removed this TODO.


> On June 11, 2019, 7:36 p.m., Benjamin Mahler wrote:
> > src/tests/master/update_framework_tests.cpp
> > Lines 714 (patched)
> > <https://reviews.apache.org/r/70755/diff/2/?file=2147660#file2147660line714>
> >
> >     newline
> >     
> >     and maybe a comment that we sanity check that it's different from the default?
seems a bit odd to check here as opposed to earlier when calling changeAllMutableFields?

After looking at the proliferating sanity checks for `ChangeAllMutableFields()`+`diff()`,
I've realized that it will probably be better to replace them (and the CHECK for the count
of fields in FrameworkInfo) with a simple unit test for this pair of helpers. This will follow
in a separate patch.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70755/#review215810
-----------------------------------------------------------


On June 12, 2019, 4:25 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70755/
> -----------------------------------------------------------
> 
> (Updated June 12, 2019, 4:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9793
>     https://issues.apache.org/jira/browse/MESOS-9793
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for the V0 UPDATE_FRAMEWORK scheduler call.
> 
> 
> Diffs
> -----
> 
>   src/tests/master/update_framework_tests.cpp 78304c211c5eb9f50ea629121a6dddfe47942e9f

> 
> 
> Diff: https://reviews.apache.org/r/70755/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message