mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Review Request 70831: Fixed synchronization in MasterTest.UpdateSlaveMessageWithPendingOffers.
Date Tue, 11 Jun 2019 12:38:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70831/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Repository: mesos


Description
-------

In order for a resource provider to have been assigned and stored an
assigned resource provider ID it needs to receive and process the
corresponding resource provider `SUBSCRIBED` event.

This patch fixes `MasterTest.UpdateSlaveMessageWithPendingOffers` so we
await the correct event. The test was previously awaiting an
`UpdateSlaveMessage` which is only tangentially related, but does not
guarantee correct event ordering.


Diffs
-----

  src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e 


Diff: https://reviews.apache.org/r/70831/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message