mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 70811: Fixed compilation error on Mac OS.
Date Tue, 11 Jun 2019 11:59:25 GMT


> On June 7, 2019, 8:55 p.m., Benjamin Bannier wrote:
> > src/slave/containerizer/mesos/launch.cpp
> > Line 508 (original), 509 (patched)
> > <https://reviews.apache.org/r/70811/diff/1/?file=2148200#file2148200line510>
> >
> >     For non-`__linux-_` cases this silently drops any configuration. Why wouldn't
we return an error in that case instead?
> 
> Andrei Budnik wrote:
>     This cpp-module has inconsistencies with handling of Linux/non-Linux cases. For example,
`prepareMounts` and `maskPath` are simply no-ops on non-Linux platforms.
>     This patch fixes compilation error. Fixing the whole inconsistency issue in a single
place is not a goal here.

Since we are already not consistent, let's return a failure here then instead.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70811/#review215759
-----------------------------------------------------------


On June 7, 2019, 7:21 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70811/
> -----------------------------------------------------------
> 
> (Updated June 7, 2019, 7:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and Jiang Yan
Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds missing switch case to fix compilation error introduced
> in `bc5a57122635`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp a69a68823842171bb15ddf34a504e5ce4af232b0 
> 
> 
> Diff: https://reviews.apache.org/r/70811/diff/1/
> 
> 
> Testing
> -------
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message