mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 70824: Fixed test `QuotaRoleAllocateNonQuotaResource`.
Date Tue, 11 Jun 2019 00:53:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70824/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9835
    https://issues.apache.org/jira/browse/MESOS-9835


Repository: mesos


Description
-------

The test was failing because:

After `agent3` is added, it misses a settle call where the allocation
of `agent3` is racy.

In addition, after MESOS-8456, the allocator now offers non-quota
resources on an agent (even that means "chopping") on top of a role's
satisfied guarantees instead of skipping the agent all-together.

This patch fixes the test by expecting the right amount of resources
to be allocated from `agent3`.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp bfea34e17151327e8c9590ecb8da74968d086ca0 


Diff: https://reviews.apache.org/r/70824/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message