mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70756: Refactored some of `MasterAPITest`s using MockMasterAPISubscriber.
Date Mon, 10 Jun 2019 03:36:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70756/#review215773
-----------------------------------------------------------


Fix it, then Ship it!




Great cleanup, thank you andrei!


src/tests/api_tests.cpp
Line 1854 (original), 1834 (patched)
<https://reviews.apache.org/r/70756/#comment302609>

    AWAIT_READY for this? ditto all others



src/tests/api_tests.cpp
Lines 2420 (patched)
<https://reviews.apache.org/r/70756/#comment302611>

    brace on next line and CamelCase



src/tests/api_tests.cpp
Lines 2572-2601 (original), 2515 (patched)
<https://reviews.apache.org/r/70756/#comment302612>

    :O
    
    thanks for cleaning this up


- Benjamin Mahler


On May 29, 2019, 6:42 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70756/
> -----------------------------------------------------------
> 
> (Updated May 29, 2019, 6:42 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch replaces reading out all Master API events (both interesting
> and uninteresting ones) in the code of the tests with setting
> expectations on `MOCK_METHOD`s of the dedicated class.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 2220cecc22778a86f0c29317adf495927e1a900d 
> 
> 
> Diff: https://reviews.apache.org/r/70756/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message