mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70752: Supported updating framework in MesosSchedulerDriver.
Date Fri, 07 Jun 2019 16:26:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70752/
-----------------------------------------------------------

(Updated June 7, 2019, 4:26 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Changes
-------

Made handling of empty `user` and `hostname` by updateFramework() consistent with that of
driver's constructor.


Bugs: MESOS-9793
    https://issues.apache.org/jira/browse/MESOS-9793


Repository: mesos


Description
-------

This patch adds a method to the MesosSchedulerDriver which updates the
FrameworkInfo (by making an UPDATE_FRAMEWORK call to the master and also
updating the FrameworkInfo stored in the driver for the purposes of
(re-)subscribing).


Diffs (updated)
-----

  include/mesos/scheduler.hpp 2ea7cdf1f9473c7b94d4282dd0df129947c97e69 
  src/sched/sched.cpp e77a02951831a7e0c5d9a9068f8d014cb1478382 


Diff: https://reviews.apache.org/r/70752/diff/2/

Changes: https://reviews.apache.org/r/70752/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message