mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.
Date Fri, 07 Jun 2019 16:21:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70671/
-----------------------------------------------------------

(Updated June 7, 2019, 4:21 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Changes
-------

Removed workaround for libprocess deadlock (which was fixed in MESOS-9808).


Bugs: MESOS-7258
    https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
-------

This patch introduces a class with mock methods for subscribing to the
events of master's V1 streaming API and setting expectations for them.


Diffs (updated)
-----

  src/Makefile.am 93b2606841745c74dc33713e6b1b2fd62a1c7e74 
  src/tests/CMakeLists.txt e6b1d8a097246f0921467d7f778034d6754fcff6 
  src/tests/master/mock_master_api_subscriber.hpp PRE-CREATION 
  src/tests/master/mock_master_api_subscriber.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/70671/diff/6/

Changes: https://reviews.apache.org/r/70671/diff/5-6/


Testing
-------

`./bin/mesos-tests.sh --verbose --gtest_filter="*UpdateFramework*" --gtest_break_on_failure
--gtest_repeat=1000` with new tests from https://reviews.apache.org/r/70534/

`./bin/mesos-tests.sh --verbose --gtest_filter="*MasterAPITest*" --gtest_break_on_failure
--gtest_repeat=1000` with refactored tests from https://reviews.apache.org/r/70756/


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message