mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70809: Fixed non-deferred callback calling Master::send() in UpdateFramework.
Date Fri, 07 Jun 2019 14:06:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70809/#review215746
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70809]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On June 7, 2019, 12:01 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70809/
> -----------------------------------------------------------
> 
> (Updated June 7, 2019, 12:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9793
>     https://issues.apache.org/jira/browse/MESOS-9793
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed non-deferred callback calling Master::send() in UpdateFramework.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp c41d912817a8e84dd3c97008dda76249fd197745 
> 
> 
> Diff: https://reviews.apache.org/r/70809/diff/1/
> 
> 
> Testing
> -------
> 
> make check + tests from https://reviews.apache.org/r/70755/ which is not committed yet:
> 
> `./bin/mesos-tests.sh --verbose --gtest_filter="UpdateFrameworkV0Test*" --gtest_break_on_failure
--gtest_repeat=1000`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message