mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 70803: Added `updateQuota` method to the allocator.
Date Fri, 07 Jun 2019 05:25:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70803/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9820
    https://issues.apache.org/jira/browse/MESOS-9820


Repository: mesos


Description
-------

This call updates a role's quota guarantees and limits.
All roles have a default quota defined as `DEFAULT_QUOTA`.
Currently, it is no guarantees and limits. Thus to "remove"
a quota, one should simply update the quota to be
`DEFAULT_QUOTA`.

Master `setQuota` and `removeQuota` calls into the allocator
are replaced with the `updateQuota`.

`setQuota` and `removeQuota` calls are now only used in the tests.
They will be deprecated once those tests are refactored.

Also fixed affected tests.


Diffs
-----

  include/mesos/allocator/allocator.hpp eafcdfdab7f0fc9570e65db15274b52495aa6de3 
  src/master/allocator/mesos/allocator.hpp 2d83f382eed9d9dca218adf84bc03883f7486349 
  src/master/allocator/mesos/hierarchical.hpp 1a3329d0e50ad2adb6aeadcd5d315eb572a85704 
  src/master/allocator/mesos/hierarchical.cpp dff1eabfc34ba132b905de9ad8ab5bd0656d8977 
  src/master/quota_handler.cpp 21176dd8a76fda621f0f98878efa67ecf862368c 
  src/tests/allocator.hpp 0718bef4de39a82dbcadebb9967d2ff1cceb1cae 
  src/tests/master_quota_tests.cpp 146b9779df307f641d415f28f70c2fb03cb870b5 


Diff: https://reviews.apache.org/r/70803/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message