mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70779: Added `<<` operator for `ResourceLimits`.
Date Thu, 06 Jun 2019 21:12:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70779/#review215729
-----------------------------------------------------------


Ship it!





src/common/resource_quantities.cpp
Lines 601-620 (patched)
<https://reviews.apache.org/r/70779/#comment302545>

    Perhaps put this immediately next to the ResourceQuantities ones so it's clear they're
copies of each other?


- Benjamin Mahler


On June 4, 2019, 4:26 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70779/
> -----------------------------------------------------------
> 
> (Updated June 4, 2019, 4:26 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `<<` operator for `ResourceLimits`.
> 
> 
> Diffs
> -----
> 
>   src/common/resource_quantities.hpp 538256bed96e72b4b61daa3052a111f59e252284 
>   src/common/resource_quantities.cpp f79b6786ccc93fff32447c9f9c3a0801500e7527 
> 
> 
> Diff: https://reviews.apache.org/r/70779/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message