mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 70782: Added a non-deterministic test for MESOS-9808.
Date Wed, 05 Jun 2019 15:42:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70782/
-----------------------------------------------------------

(Updated June 5, 2019, 3:42 p.m.)


Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao.


Changes
-------

Optimized this test for catching the deletion by the decomissioned EventQueue:
- introduced the gate as suggested (improves deadlock probability) and removed the dispatches
before terminating process A (when the gate is added, they have no effect and only waste time)
- reduced number of dispatches in each iteration to 10
- increased iteration count from 100 to 5000

Also cleaned up the code.


Summary (updated)
-----------------

Added a non-deterministic test for MESOS-9808.


Bugs: MESOS-9808
    https://issues.apache.org/jira/browse/MESOS-9808


Repository: mesos


Description (updated)
-------

Added a non-deterministic test for MESOS-9808.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/process_tests.cpp 05dc5ec2fdc74a989689e4378bef775bcf2b7a87



Diff: https://reviews.apache.org/r/70782/diff/2/

Changes: https://reviews.apache.org/r/70782/diff/1-2/


Testing
-------

Without a fix from https://reviews.apache.org/r/70778/ - deadlocks 100 out of 100 times on
the hardware I used, due to the same reason as the code in MESOS-9808.

With a fix from https://reviews.apache.org/r/70778/ - one run takes around 2 seconds. Sometimes
still deadlocks with similar stacks.


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message