mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70777: WIP: Stopped using rDNS for hostname validation.
Date Tue, 04 Jun 2019 01:07:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70777/#review215668
-----------------------------------------------------------



Bad review!

Reviews applied: [70777, 70749, 70748, 70747]

Error:
2019-06-04 01:07:42 URL:https://reviews.apache.org/r/70777/diff/raw/ [8277/8277] -> "70777.patch"
[1]
error: patch failed: 3rdparty/libprocess/src/tests/ssl_tests.cpp:750
error: 3rdparty/libprocess/src/tests/ssl_tests.cpp: patch does not apply

- Mesos Reviewbot


On June 3, 2019, 5:19 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70777/
> -----------------------------------------------------------
> 
> (Updated June 3, 2019, 5:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9811
>     https://issues.apache.org/jira/browse/MESOS-9811
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Before this change, libprocess would validate that a given server
> certificate matches the first hostname configured in a PTR record
> for that servers IP address.
> 
> Instead, we now check that the server certificate matches the
> hostname that was originally passed to `connect()`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/address.hpp e740e840c38381bafd7a1a7fcde5f963832ac1fb

>   3rdparty/libprocess/src/http.cpp 3e73ee936f5c6329f41704a179f3d88ab65dfb6d 
>   3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp 29a1bf71c1df9d80370455a6269ecea0ec4193b0

>   3rdparty/libprocess/src/tests/http_tests.cpp 97aaf3ed3d4fab6d717d5c9b6d12402562ac6b46

>   3rdparty/libprocess/src/tests/ssl_tests.cpp 6b8496aeeed79ae1bd39d7013f4f403b248fdd4c

> 
> 
> Diff: https://reviews.apache.org/r/70777/diff/1/
> 
> 
> Testing
> -------
> 
> Some tests are failing, hence WIP status :/
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message