mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70690: Added `repeated QuotaConfig` to `QuotaStatus`.
Date Mon, 03 Jun 2019 18:57:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70690/#review215653
-----------------------------------------------------------


Ship it!




Can you file the appropriate ticket for the 2.0 work that the description mentions? Without
tickets we'll never be able to get rid of all the deprecated stuff when we do a 2.0. I can't
remember if we have a label, but for now maybe a target version of 2.0.0 is enough (but not
ideal).

- Benjamin Mahler


On May 21, 2019, 3:22 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70690/
> -----------------------------------------------------------
> 
> (Updated May 21, 2019, 3:22 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also marked the `infos` field as deprecated.
> 
> `QuotaStatus` is returned by `GET_QUOTA` and `GET /quota`.
> As we introduce quota limits, a new mesage `QuotaConfig`
> is introduced to describe the quota configuration. For
> backwards compatibility, we will fill in both fields
> until `QuotaInfo` is removed (in Mesos 2.0).
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 682c0cc40529839ad90c5f412532269861584b71 
>   include/mesos/v1/quota/quota.proto b109ca2a9c7c4b8f1444cc654298c9e580d0ca42 
> 
> 
> Diff: https://reviews.apache.org/r/70690/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message