mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Janco <jjanco....@gmail.com>
Subject Re: Review Request 70581: Add flag to decouple docker runtime.
Date Wed, 15 May 2019 23:21:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70581/
-----------------------------------------------------------

(Updated May 15, 2019, 11:21 p.m.)


Review request for mesos, Gilbert Song and James Peach.


Bugs: MESOS-9760
    https://issues.apache.org/jira/browse/MESOS-9760


Repository: mesos


Description
-------

Docker runtime isolator propagates manifest configuration metadata.
This is not always desirable, e.g. a customer may want to ignore the
defined WORKDIR/ENV defined in the manifest. This patch decouples
isolator work from the selection of Docker as an image provider.

https://issues.apache.org/jira/browse/MESOS-9760


Diffs (updated)
-----

  docs/configuration/agent.md 04d7114e92c189afd04a8889b3ab853ade9deec6 
  docs/upgrades.md ece8462b9950626166c832d3b554ad51f68f42e1 
  src/slave/containerizer/mesos/isolators/docker/runtime.cpp 53d00082dae4980426294f0f4be210e53c7c8b48

  src/slave/flags.hpp 09921cb6172202b5c1d2f8d03f9ccaeb3d0e8c94 
  src/slave/flags.cpp 49a350f9e13409493fa9612c53d9d58b62122371 
  src/tests/containerizer/provisioner_docker_tests.cpp 1c5d72091d570001ad543e342ab0b9128ffc01ae



Diff: https://reviews.apache.org/r/70581/diff/6/

Changes: https://reviews.apache.org/r/70581/diff/5-6/


Testing
-------


Thanks,

Jacob Janco


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message