mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 70581: Add flag to decouple docker runtime.
Date Wed, 15 May 2019 12:16:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70581/#review215281
-----------------------------------------------------------




docs/upgrades.md
Lines 508 (patched)
<https://reviews.apache.org/r/70581/#comment301942>

    You can link the flag to it's official doc anchor:
    ```
    [`--docker_ignore_runtime`](configuration/agent.md#docker_ignore_runtime)
    ```
    
    Phrase the paragraph like this:
    ```
    A new [--flag]() has been added. This causes the agent to ignore any runtime configuration
present in Docker images.
    ```



src/slave/containerizer/mesos/containerizer.cpp
Lines 231 (patched)
<https://reviews.apache.org/r/70581/#comment301935>

    Should be `--docker_ignore_runtime`. Make it `if the xxx flag is present`.



src/slave/containerizer/mesos/containerizer.cpp
Lines 233 (patched)
<https://reviews.apache.org/r/70581/#comment301936>

    This fits nicely on one line.



src/slave/containerizer/mesos/provisioner/store.cpp
Lines 82 (patched)
<https://reviews.apache.org/r/70581/#comment301937>

    Sorry, you were right about this originally. As @qianzhang points out, if we keep this
check, we preserve our ability to change the implementation in the future.



src/tests/containerizer/provisioner_docker_tests.cpp
Lines 1389 (patched)
<https://reviews.apache.org/r/70581/#comment301938>

    I think that the middle sentence here isn't necessary. Could you please capitalize `Docker`
consistently?



src/tests/containerizer/provisioner_docker_tests.cpp
Lines 1394 (patched)
<https://reviews.apache.org/r/70581/#comment301941>

    You can drop the `CURL` token from here since you don't have a curl dependency.



src/tests/containerizer/provisioner_docker_tests.cpp
Lines 1414 (patched)
<https://reviews.apache.org/r/70581/#comment301939>

    I guess you will have to add `docker/runtime` back to the isolation.



src/tests/containerizer/provisioner_docker_tests.cpp
Lines 1470 (patched)
<https://reviews.apache.org/r/70581/#comment301940>

    Do you really need 60sec here? Unless there's a good reason, just use `AWAIT_READY()`.


- James Peach


On May 14, 2019, 6:51 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70581/
> -----------------------------------------------------------
> 
> (Updated May 14, 2019, 6:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9760
>     https://issues.apache.org/jira/browse/MESOS-9760
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Docker runtime isolator propagates manifest configuration metadata.
> This is not always desirable, e.g. a customer may want to ignore the
> defined WORKDIR/ENV defined in the manifest. This patch decouples
> isolator work from the selection of Docker as an image provider.
> 
> https://issues.apache.org/jira/browse/MESOS-9760
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 04d7114e92c189afd04a8889b3ab853ade9deec6 
>   docs/upgrades.md ece8462b9950626166c832d3b554ad51f68f42e1 
>   src/slave/containerizer/mesos/containerizer.cpp c4a6827c5574586475152b1dc31572d6e1821a82

>   src/slave/containerizer/mesos/provisioner/store.cpp 11fce0eb47e9e6dfce6289afe04a1d58a0c4461a

>   src/slave/flags.hpp 09921cb6172202b5c1d2f8d03f9ccaeb3d0e8c94 
>   src/slave/flags.cpp 49a350f9e13409493fa9612c53d9d58b62122371 
>   src/tests/containerizer/provisioner_docker_tests.cpp 1c5d72091d570001ad543e342ab0b9128ffc01ae

> 
> 
> Diff: https://reviews.apache.org/r/70581/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message