mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 70581: Add flag ignoring docker manifest config metadata.
Date Tue, 14 May 2019 07:20:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70581/#review215239
-----------------------------------------------------------



You dropeed the change to `src/slave/containerizer/mesos/provisioner/store.cpp`, but AFAICT,
you still need it.

Please update the relevant `docker/runtime` documentation in ` docs/isolators/docker-runtime.md`
and `docs/container-image.md`.


src/tests/containerizer/provisioner_docker_tests.cpp
Lines 1399 (patched)
<https://reviews.apache.org/r/70581/#comment301863>

    For consistency with other tests:
    ```
    const string registry = path::join(sandbox.get(), "registry");
    ```



src/tests/containerizer/provisioner_docker_tests.cpp
Lines 1443 (patched)
<https://reviews.apache.org/r/70581/#comment301868>

    Add a comment here, explaining what we expect the task command to do (and why).



src/tests/containerizer/provisioner_docker_tests.cpp
Lines 1449 (patched)
<https://reviews.apache.org/r/70581/#comment301867>

    You can replace this with
    ```
    TaskInfo = createTask(
        offer.slave_id(),
        offer.resoources(),
        "test -z $DOCKER_RUNTIME_ENV");
    ```


- James Peach


On May 14, 2019, 3:13 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70581/
> -----------------------------------------------------------
> 
> (Updated May 14, 2019, 3:13 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9760
>     https://issues.apache.org/jira/browse/MESOS-9760
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Docker runtime isolator propagates manifest configuration metadata.
> This is not always desirable, e.g. a customer may want to ignore the
> defined WORKDIR/ENV defined in the manifest.
> 
> https://issues.apache.org/jira/browse/MESOS-9760
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 04d7114e92c189afd04a8889b3ab853ade9deec6 
>   docs/upgrades.md ece8462b9950626166c832d3b554ad51f68f42e1 
>   src/slave/containerizer/mesos/containerizer.cpp c4a6827c5574586475152b1dc31572d6e1821a82

>   src/slave/flags.hpp 09921cb6172202b5c1d2f8d03f9ccaeb3d0e8c94 
>   src/slave/flags.cpp 49a350f9e13409493fa9612c53d9d58b62122371 
>   src/tests/containerizer/provisioner_docker_tests.cpp 1c5d72091d570001ad543e342ab0b9128ffc01ae

> 
> 
> Diff: https://reviews.apache.org/r/70581/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message