mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70589: Logged when `/__processes__` returns.
Date Fri, 10 May 2019 16:34:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70589/#review215189
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/src/process.cpp
Lines 3412 (patched)
<https://reviews.apache.org/r/70589/#comment301733>

    Perhaps a TODO to generalize the response logging in libprocess?


- Benjamin Mahler


On May 9, 2019, 1:09 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70589/
> -----------------------------------------------------------
> 
> (Updated May 9, 2019, 1:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-9766
>     https://issues.apache.org/jira/browse/MESOS-9766
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a log entry when a response with generated by `/__processes__`
> is about to be returned to the client.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 124836472313721a5dbfe4b1ca55f0da3cecd66b 
> 
> 
> Diff: https://reviews.apache.org/r/70589/diff/1/
> 
> 
> Testing
> -------
> 
> built & run on Mac OS 10.13.6
> 
> ```
> I0503 13:13:00.885133 59219968 process.cpp:3599] Handling HTTP event for process '__processes__'
with path: '/__processes__'
> I0503 13:13:00.886037 59219968 process.cpp:3412] HTTP GET for /__processes__ from 192.168.178.47:59548:
'200 OK' after 1.06214ms
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message