mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 70581: Add flag ignoring docker manifest config metadata.
Date Thu, 09 May 2019 23:10:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70581/#review215172
-----------------------------------------------------------




docs/configuration/agent.md
Lines 648 (patched)
<https://reviews.apache.org/r/70581/#comment301710>

    I think that the way this is phrased, an operator will reasonably expect that just specifying
this flag will be enough to get the desired result. It's not clear that you also have to remove
the `docker/runtime` isolator.
    
    So, I suggest that we add a flag check in `MesosContainerizer::create` and erase `docker/runtime`
from the isolator set if this flag is specified.
    
    Then we can rename this flag to `--ignore_docker_runtime` which is a more consistent with
the rest of the Mesos configuration.
    
    Finally, we should also update the documentation at `docs/isolators/docker-runtime.md`
to mention the flag.



src/slave/containerizer/mesos/provisioner/store.cpp
Lines 79 (patched)
<https://reviews.apache.org/r/70581/#comment301709>

    Better to just add this to the existing conditional (in the middle).


- James Peach


On May 9, 2019, 7 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70581/
> -----------------------------------------------------------
> 
> (Updated May 9, 2019, 7 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9760
>     https://issues.apache.org/jira/browse/MESOS-9760
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Docker runtime isolator propagates manifest configuration metadata.
> This is not always desirable, e.g. a customer may want to ignore the
> defined WORKDIR/ENV defined in the manifest.
> 
> https://issues.apache.org/jira/browse/MESOS-9760
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 04d7114e92c189afd04a8889b3ab853ade9deec6 
>   docs/upgrades.md ece8462b9950626166c832d3b554ad51f68f42e1 
>   src/slave/containerizer/mesos/provisioner/store.cpp 11fce0eb47e9e6dfce6289afe04a1d58a0c4461a

>   src/slave/flags.hpp 09921cb6172202b5c1d2f8d03f9ccaeb3d0e8c94 
>   src/slave/flags.cpp 49a350f9e13409493fa9612c53d9d58b62122371 
> 
> 
> Diff: https://reviews.apache.org/r/70581/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message