mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70570: Logged headroom related info in the allocator.
Date Thu, 09 May 2019 21:10:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70570/#review215168
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.cpp
Lines 2012-2015 (patched)
<https://reviews.apache.org/r/70570/#comment301703>

    I don't think we need to quote out the variables like this, as it tends to lead to a more
verbose comment than necessary, e.g.:
    
    ```
    For logging purposes, we track the number of agents that had
    resources held back for quota headroom, as well as how many
    resources in total were held back.
    ```



src/master/allocator/mesos/hierarchical.cpp
Lines 2119 (patched)
<https://reviews.apache.org/r/70570/#comment301704>

    more importantly, we do not track it there? right? (the logging seems secondary to the
fact that we don't track the information in the first stage)
    
    probably this comment about how we track it should be up above the variables rather than
in the logging of it?



src/master/allocator/mesos/hierarchical.cpp
Lines 2128 (patched)
<https://reviews.apache.org/r/70570/#comment301705>

    is this accurate?
    
    it can actually be a combination of: filtering, limits being reached, and suppressed roles?
    
    Maybe don't include this for now and just log the available headroom?


- Benjamin Mahler


On May 9, 2019, 12:22 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70570/
> -----------------------------------------------------------
> 
> (Updated May 9, 2019, 12:22 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9759
>     https://issues.apache.org/jira/browse/MESOS-9759
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch logs `requiredHeadroom` and `availableHeadroom`
> before each allocation cycle and logs `requiredHeadroom`,
> resources and number of agents held back for quota `headroom`
> as well as resources filtered at the end of each allocation
> cycle.
> 
> While we also held resources back for quota headroom in the
> first stage, we do not log it there. This is because in the
> second stage, we try to allocate all resources (including the
> ones held back in the first stage). Thus only resources held
> back in the second stage are truly held back for the whole
> allocation cycle.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87

> 
> 
> Diff: https://reviews.apache.org/r/70570/diff/5/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message