mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 70478: Improved operation feedback example framework.
Date Wed, 08 May 2019 20:47:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70478/#review215136
-----------------------------------------------------------


Ship it!





src/examples/operation_feedback_framework.cpp
Lines 322 (patched)
<https://reviews.apache.org/r/70478/#comment301635>

    Good that you fixed the behavior of using very long durations at some point ;)


- Benjamin Bannier


On April 16, 2019, 1:35 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70478/
> -----------------------------------------------------------
> 
> (Updated April 16, 2019, 1:35 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the operation feedback example framework use a long
> filter when accepting offers and revive offers when it receives an
> `OPERATION_FINISH` operation status update.
> 
> 
> Diffs
> -----
> 
>   src/examples/operation_feedback_framework.cpp ab19605dda069db06b6215a95049014244fc2d4f

> 
> 
> Diff: https://reviews.apache.org/r/70478/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message