mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 70562: Add LIBPROCESS_SSL_ENABLE_TLS_V1_3
Date Mon, 29 Apr 2019 16:08:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70562/#review214949
-----------------------------------------------------------


Ship it!




Thanks so much Stephane. Looks slick -- Benno will go ahead and land this with the small fix
he mentioned already (thanks Benno :))

- Till Toenshoff


On April 29, 2019, 6:43 a.m., St├ęphane Cottin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70562/
> -----------------------------------------------------------
> 
> (Updated April 29, 2019, 6:43 a.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-9730
>     https://issues.apache.org/jira/browse/MESOS-9730
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When building mesos with libopenssl >= 1.1.1, TLS1.3 is enabled by default. This causes
major communication issues between executors and agents.
> 
> This patch adds new `LIBPROCESS_SSL_ENABLE_TLS_V1_3` env var, disabled by default.
> Should be changed to enabled by default when full openssl >= 1.1 support will land.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/ssl/flags.hpp 3806266fb 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp e173b3224 
>   3rdparty/libprocess/src/openssl.hpp 0c4192f90 
>   3rdparty/libprocess/src/openssl.cpp a4d503642 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 5e994498d 
> 
> 
> Diff: https://reviews.apache.org/r/70562/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> St├ęphane Cottin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message