mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70564: Fixed a performance issue in the random sorter.
Date Mon, 29 Apr 2019 15:34:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70564/#review214947
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On April 29, 2019, 5:28 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70564/
> -----------------------------------------------------------
> 
> (Updated April 29, 2019, 5:28 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a performance issue in the random sorter.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/random/sorter.cpp f4132bbacd590389ae156f964d2463e79db5e27f

> 
> 
> Diff: https://reviews.apache.org/r/70564/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Benchmarking:
> Optimized build with QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5
> 
> Before:
> Added 3000 agents in 88.759226ms
> Added 3000 frameworks in 19.519956346secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks, with random sorter
> Made 3856 allocations in 19.091583161secs
> Made 0 allocation in 18.428433277secs
> 
> After:
> 
> Added 3000 agents in 87.972155ms
> Added 3000 frameworks in 19.372715548secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks
> Made 3856 allocations in 15.846013158secs
> Made 0 allocation in 15.756238099secs
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message