mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 70538: WIP: Fixed upgrade path for tasks with invalid protobuf unions.
Date Thu, 25 Apr 2019 20:09:47 GMT


> On April 25, 2019, 11:05 a.m., Vinod Kone wrote:
> > I would suggest we tweak the validation for 1.13.0 to log a warning instead of throwing
an error and add a deprecation warning that "union" protobufs will be validated in a future
release in the CHANGELOG. In the meantime, we can give times to frameworks to fix their bug,
as well as figure what's the best way to handle existing tasks with invalid protos.

That is probably a better approach.  This patch only deals with reregistration, and does not
give time for frameworks to fix their protobufs.

Here's the validation tweak: https://reviews.apache.org/r/70546/


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70538/#review214888
-----------------------------------------------------------


On April 23, 2019, 8:28 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70538/
> -----------------------------------------------------------
> 
> (Updated April 23, 2019, 8:28 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benno Evers, and Greg Mann.
> 
> 
> Bugs: MESOS-9740
>     https://issues.apache.org/jira/browse/MESOS-9740
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As part of MESOS-6874, the master now validates protobuf unions
> passed as part of an ExecutorInfo::ContainerInfo.  This prevents a
> task from specifying, for example, a ContainerInfo::MESOS, but filling
> out the `docker` field (which is then ignored by the agent).
> 
> However, if a task was already launched with an invalid protobuf
> union, the same validation will happen when the agent tries to
> reregister with the master.  In this case, if the master is upgraded
> to validate protobuf unions, the agent reregistration will be rejected.
> 
> This adds a hack to wipe invalid fields from the agent's reregistration
> message before sending it to the master.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 95f05a18c7905d5032de1cd35726ac3a17f0b682 
> 
> 
> Diff: https://reviews.apache.org/r/70538/diff/1/
> 
> 
> Testing
> -------
> 
> WIP!!!
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message