mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70532: Added UpdateFramework submessage.
Date Wed, 24 Apr 2019 19:43:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/#review214865
-----------------------------------------------------------



How about: "Added an UPDATE_FRAMEWORK scheduler::Call."

Can you add a description and some context to the description (e.g. that it's based on https://reviews.apache.org/r/66228/)?


include/mesos/scheduler/scheduler.proto
Lines 492-493 (patched)
<https://reviews.apache.org/r/70532/#comment301136>

    This will be the documentation for framework developers, so we should spell out separately
and clearly which fields can't be mutated, e.g.:
    
    ```
    // Updates the FrameworkInfo. All fields can be updated except
    // the following:
    //
    //   * FrameworkInfo.user
    //   * FrameworkInfo.checkpoint 
    //
    // The possible responses are:
    //
    //   * 200 OK: ...
    //   ...
    ```



include/mesos/scheduler/scheduler.proto
Lines 494 (patched)
<https://reviews.apache.org/r/70532/#comment301135>

    newline before this list of responses



include/mesos/scheduler/scheduler.proto
Lines 497 (patched)
<https://reviews.apache.org/r/70532/#comment301134>

    The next review says 403 and 409, but this one uses 401?


- Benjamin Mahler


On April 23, 2019, 7:04 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70532/
> -----------------------------------------------------------
> 
> (Updated April 23, 2019, 7:04 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
>     https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the UpdateFramework submessage.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8 
>   include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a

> 
> 
> Diff: https://reviews.apache.org/r/70532/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message