mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70530: Added a method for strict validation of a FrameworkInfo update.
Date Wed, 24 Apr 2019 19:25:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70530/#review214862
-----------------------------------------------------------



I'm a bit lost looking at this change, can you add an explanatory description to the commit?
Also, be sure to explain what "strict" means in this context and why we need a notion of strictness
and non-strictness.


src/master/master.hpp
Lines 2418-2423 (patched)
<https://reviews.apache.org/r/70530/#comment301131>

    Does this need to be a member function? Is it possible to pull it up into the stateless
validation header so that we can unit test it? E.g. pass in old vs new framework info into
the function rather than rely on the master's Framework struct state


- Benjamin Mahler


On April 23, 2019, 7:04 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70530/
> -----------------------------------------------------------
> 
> (Updated April 23, 2019, 7:04 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
>     https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a method for a strict validation of a FrameworkInfo update.
> 
> 
> Diffs
> -----
> 
>   src/master/framework.cpp 05f5514c589b2dba08afe77281e5fbc4e29f232b 
>   src/master/master.hpp 94891af9deeaddb3333fc9d6eabb243aed97f7b7 
>   src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084 
> 
> 
> Diff: https://reviews.apache.org/r/70530/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message