mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 70538: WIP: Fixed upgrade path for tasks with invalid protobuf unions.
Date Wed, 24 Apr 2019 09:31:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70538/#review214849
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70538']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3252/mesos-review-70538

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3252/mesos-review-70538/logs/mesos-tests.log):

```
I0424 09:31:02.051659 73824 master.cpp:3312] Disconnecting agent d7b1510a-c334-4e0e-b29f-4e608ed96fc4-S0
at slave(504)@192.10.1.4:52521 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0424 09:31:02.051659 73824 master.cpp:3331] Deactivating agent d7b1510a-c334-4e0e-b29f-4e608ed96fc4-S0
at slave(504)@192.10.1.4:52521 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0424 09:31:02.051659 71552 hierarchical.cpp:392] Removed framework d7b1510a-c334-4e0e-b29f-4e608ed96fc4-0000
I0424 09:31:02.052666 71552 hierarchical.cpp:829] Agent d7b1510a-c334-4e0e-b29f-4e608ed96fc4-S0
deactivated
I0424 09:31:02.053719 73276 containerizer.cpp:2576] Destroying container 5b37002c-0a30-4822-bd86-bf909080a220
in RUNNING state
I0424 09:31:02.053719 73276 containerizer.cpp:3278] Transitioning the state of container 5b37002c-0a30-4822-bd86-bf909080a220
from RUNNING to DESTROYING
I0424 09:31:02.053719 73276 launcher.cpp:161] Asked to destroy container 5b37002c-0a30-4822-bd86-bf909080a220
W0424 09:31:02.055660 69164 pro[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
(876 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (898 ms total)

[----------] Global test environment tear-down
[==========] 1166 tests from 109 test cases ran. (596766 ms total)
[  PASSED  ] 1163 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

cess.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=6276 to peer '192.10.1.4:54931':
IO failed with error code: The specified network name is no longer available.

W0424 09:31:02.055660 69164 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=6268
to peer '192.10.1.4:54932': IO failed with error code: The specified network name is no longer
available.

I0424 09:31:02.154880 71552 containerizer.cpp:3117] Container 5b37002c-0a30-4822-bd86-bf909080a220
has exited
I0424 09:31:02.189864 77420 master.cpp:1135] Master terminating
I0424 09:31:02.190870 73276 hierarchical.cpp:680] Removed agent d7b1510a-c334-4e0e-b29f-4e608ed96fc4-S0
I0424 09:31:03.654887 69164 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 24, 2019, 3:28 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70538/
> -----------------------------------------------------------
> 
> (Updated April 24, 2019, 3:28 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Benno Evers, and Greg Mann.
> 
> 
> Bugs: MESOS-9740
>     https://issues.apache.org/jira/browse/MESOS-9740
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As part of MESOS-6874, the master now validates protobuf unions
> passed as part of an ExecutorInfo::ContainerInfo.  This prevents a
> task from specifying, for example, a ContainerInfo::MESOS, but filling
> out the `docker` field (which is then ignored by the agent).
> 
> However, if a task was already launched with an invalid protobuf
> union, the same validation will happen when the agent tries to
> reregister with the master.  In this case, if the master is upgraded
> to validate protobuf unions, the agent reregistration will be rejected.
> 
> This adds a hack to wipe invalid fields from the agent's reregistration
> message before sending it to the master.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 95f05a18c7905d5032de1cd35726ac3a17f0b682 
> 
> 
> Diff: https://reviews.apache.org/r/70538/diff/1/
> 
> 
> Testing
> -------
> 
> WIP!!!
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message