mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70498: Simplified Sorter::add(client) implementations.
Date Fri, 19 Apr 2019 18:45:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70498/#review214770
-----------------------------------------------------------




src/master/allocator/sorter/drf/sorter.cpp
Line 169 (original), 153 (patched)
<https://reviews.apache.org/r/70498/#comment301030>

    This check should be done at the start of the function? i.e. make sure we're not adding
a client that's already added



src/master/allocator/sorter/random/sorter.cpp
Line 165 (original), 149 (patched)
<https://reviews.apache.org/r/70498/#comment301031>

    Ditto here


- Benjamin Mahler


On April 17, 2019, 9:39 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70498/
> -----------------------------------------------------------
> 
> (Updated April 17, 2019, 9:39 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The existing logic is rather hard to understand and there is no
> guiding explanation of the algorithm.
> 
> This re-writes the logic into an easier to understand approach,
> along with a comment at the top that explains the two phase
> algorithm.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/drf/sorter.cpp 554ac84ee585d1d07048a58cf7d7d1e6586252ee

>   src/master/allocator/sorter/random/sorter.cpp bbe130dbf3b158ea14f9572bc5d14200fcd85127

> 
> 
> Diff: https://reviews.apache.org/r/70498/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message