mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70484: Supported docker manifest v2s2 config with image GC.
Date Tue, 16 Apr 2019 14:24:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70484/#review214694
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On April 16, 2019, 2:08 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70484/
> -----------------------------------------------------------
> 
> (Updated April 16, 2019, 2:08 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Jie Yu, Qian Zhang, and Zhitao Li.
> 
> 
> Bugs: MESOS-9704
>     https://issues.apache.org/jira/browse/MESOS-9704
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After the docker manifest v2 schema2 support, the manifest config
> is saved as a layer in image store. However, the config file
> cannot survive if the image GC is triggered.
> 
> This patch supports checkpointing the config path in provisioner,
> so that the provisioner has the information of configs so that
> they will not be deleted during GC.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 53de6253257b37173ccc8b7f90f8aa422ed0430a

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 36b2c7de87bcdfd3e2af6477499572b235ea1933

>   src/slave/containerizer/mesos/provisioner/provisioner.cpp ac402fbead81e4b356cb35cea08a00049002e870

> 
> 
> Diff: https://reviews.apache.org/r/70484/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message