mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70441: Made CSI volume managers no longer maintain a list of services.
Date Wed, 10 Apr 2019 04:45:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70441/
-----------------------------------------------------------

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
-------

Since the service manager is passed in, there is no need for the volume
manager to maintain a separated list of services provided by the service
manager. This patch cleans up this part and make the service manager
exposes the list of services it contains. It also add more validation
in the service manager to make the code more cohesive.


Diffs
-----

  src/csi/service_manager.hpp 5dd6bc7e044670c7416e2fc452ef46a2a50a6cf5 
  src/csi/service_manager.cpp 0a3663cfd0dae2672a11eebcb6ffa3f8fad68ae0 
  src/csi/v0_volume_manager.hpp 6c15f290389dfa150edf073c6033f0580e2e32b3 
  src/csi/v0_volume_manager.cpp 02de17ee33193a078617210959a944501132fd5c 
  src/csi/v0_volume_manager_process.hpp c3cd6caa0e53bdb19213e1383f458ce7aab9485d 
  src/csi/v1_volume_manager.hpp f8e609501253de37b9a9fa3ae0c760329e6ecfd4 
  src/csi/v1_volume_manager.cpp bd334f1340be7fc3ef3faba56dfff8ffa69c2ea0 
  src/csi/v1_volume_manager_process.hpp 1c80399be434781401acda753ed5d69e1dc12a32 
  src/csi/volume_manager.hpp cc20f461868b6b578b7e55ca0df66fbe26d8cd49 
  src/csi/volume_manager.cpp cbe45cb439defbdd22bc57648b455e69679bdb4f 
  src/resource_provider/storage/provider.cpp 2dc5c26b11f3fff179b4357b0dcc149e93d4e12f 


Diff: https://reviews.apache.org/r/70441/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message