mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69813: Improved error printing for gRPC statuses.
Date Fri, 25 Jan 2019 16:02:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69813/#review212326
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/grpc.cpp
Lines 22 (patched)
<https://reviews.apache.org/r/69813/#comment298084>

    Unused.



3rdparty/libprocess/src/grpc.cpp
Lines 63-64 (patched)
<https://reviews.apache.org/r/69813/#comment298085>

    I'd suggest to just stringify this one as well as to reach here there might be an error
in gRPC, not our code.



3rdparty/libprocess/src/grpc.cpp
Lines 75 (patched)
<https://reviews.apache.org/r/69813/#comment298086>

    Remove this modification?


- Benjamin Bannier


On Jan. 24, 2019, 7:09 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69813/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2019, 7:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9517
>     https://issues.apache.org/jira/browse/MESOS-9517
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch prepends the error message of a `process::grpc::StatusError`
> with its status code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/grpc.hpp 28c9cada1bb986af950bfdaa05f8307a062708b7

>   3rdparty/libprocess/src/grpc.cpp 4e4f989e4744fb11b07c75999fb4e6668277d2fc 
> 
> 
> Diff: https://reviews.apache.org/r/69813/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message