mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69811: Preliminary SLRP refactoring for RPC retry.
Date Fri, 25 Jan 2019 13:15:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69811/#review212320
-----------------------------------------------------------


Ship it!




LGTM, still need to go through the rest of the chain.


src/resource_provider/storage/provider.cpp
Lines 395 (patched)
<https://reviews.apache.org/r/69811/#comment298069>

    Nit: We could slightly change the emphasis here, e.g.,
    ```
    Wrapper functions to make CSI calls and update RPC metrics.
    
    The call is made asynchronously and e.g., no guarantee is provided on the
    order in which calls are sent. With that callers need to either ensure to
    not have multiple conflicting calls in flight, or treat results idempotently.
    
    NOTE: In this module we currently ensure this by 1) resource locking to
    forbid concurrent calls on the same volume, and 2) no profile update while
    there are ongoing `CREATE_DISK` or `DESTROY_DISK` operations.
    
    NOTE: Since ...
    ```


- Benjamin Bannier


On Jan. 24, 2019, 7:05 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69811/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2019, 7:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9517
>     https://issues.apache.org/jira/browse/MESOS-9517
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch refactors the `StorageLocalResourceProvider::call` function
> to obtain the latest service future through `getService` before making
> the actual RPC call. The subsequent patch would utilize this to support
> RPC retry across plugin restarts.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c

> 
> 
> Diff: https://reviews.apache.org/r/69811/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message