mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69795: Made agent recover atomically checkpointed resources and operations.
Date Thu, 24 Jan 2019 22:39:32 GMT


> On Jan. 23, 2019, 4:58 p.m., Greg Mann wrote:
> > src/slave/slave.cpp
> > Lines 7356-7380 (patched)
> > <https://reviews.apache.org/r/69795/diff/1/?file=2120593#file2120593line7356>
> >
> >     If we change the checkpointing code to checkpoint the operation _before_ it
is applied, then we need to apply speculative operations here as well, since `updateOperation()`
only applies non-speculative operations when they transition to terminal.

Revision two makes the agent apply pending operations and adds some additional checks.


> On Jan. 23, 2019, 4:58 p.m., Greg Mann wrote:
> > src/slave/slave.cpp
> > Lines 7381-7384 (patched)
> > <https://reviews.apache.org/r/69795/diff/1/?file=2120593#file2120593line7381>
> >
> >     Should we add a `CHECK(operation->latest_status().state() == OPERATION_FINISHED)`
here?

Dropping this issue per offline discussion.

Even though right now operations can either be pending or finished, future versions of the
agent might use other terminal states, so the check might be too strict.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69795/#review212257
-----------------------------------------------------------


On Jan. 24, 2019, 2:37 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69795/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2019, 2:37 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
>     https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made agent recover atomically checkpointed resources and operations.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 2bcd7a93a8f25b77c71c7f931bfaac87649f987c 
>   src/slave/slave.cpp ed92f672f5155d70a36ba3619bb6f06fa09bc836 
>   src/slave/state.hpp e2180ae37a65a57d1edb29d2ad6cc8232029906e 
>   src/slave/state.cpp ae16d6f656cff71bcbdd4ffb02888024530b9274 
> 
> 
> Diff: https://reviews.apache.org/r/69795/diff/4/
> 
> 
> Testing
> -------
> 
> Current tests still pass.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message