mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69793: Added the `ResourceState` agent protobuf message.
Date Wed, 23 Jan 2019 18:25:17 GMT


> On Jan. 22, 2019, 2:55 p.m., Greg Mann wrote:
> > src/Makefile.am
> > Lines 980 (patched)
> > <https://reviews.apache.org/r/69793/diff/1/?file=2120585#file2120585line980>
> >
> >     Did we consider `slave/state.proto` for this filename? Sorry I can't recall
:) WDYT?

I think we briefly chatted about it and thought that it would be nice to have a file where
we can add in the future more messages that might be used by the agent.... but I am also 100%
OK renaming the file to `slave/state.proto` =).


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69793/#review212205
-----------------------------------------------------------


On Jan. 18, 2019, 3 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69793/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2019, 3 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
>     https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This protobuf message will be used by the agent to atomically checkpoint
> resources and operations.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf 
>   src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 
>   src/slave/slave.proto PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69793/diff/1/
> 
> 
> Testing
> -------
> 
> Current tests still pass.
> 
> Compiled new proto with both cmake and autotools.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message