mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.
Date Tue, 15 Jan 2019 23:13:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69708/
-----------------------------------------------------------

(Updated Jan. 15, 2019, 11:13 p.m.)


Review request for mesos, Benjamin Bannier, BenjaminVW BenjaminVW, Gastón Kleiman, Joseph
Wu, Till Toenshoff, and Vinod Kone.


Changes
-------

Addressed Benjamin's comment.


Bugs: MESOS-9519
    https://issues.apache.org/jira/browse/MESOS-9519


Repository: mesos


Description
-------

This patch cherry-picks an unofficial commit to disable ALPN compilation
if only OpenSSL 1.0.1 is on the system.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 703808d063e4bba58f647b5d48b78724003bcc4e 
  3rdparty/grpc-1.10.0.patch 655f00387a6b308b653b23053419ec05c8b22144 
  3rdparty/grpc.md e06843c8b6038eb9fb809241686fd611d1daedc8 


Diff: https://reviews.apache.org/r/69708/diff/6/

Changes: https://reviews.apache.org/r/69708/diff/5-6/


Testing
-------

OS=ubuntu:14.04 BUILDTOOL=cmake COMPILER=gcc CONFIGURATION='--verbose --enable-libevent --enable-ssl'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' support/docker-build.sh
OS=ubuntu:16.04 BUILDTOOL=cmake COMPILER=gcc CONFIGURATION='--verbose --enable-libevent --enable-ssl'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' support/docker-build.sh (to make sure that it works
with OpenSSL 1.0.2. Also manually inspected that ALPN symbols are linked).
Manually tested on Debian 9 to ensure that the CMake rule can find its OpenSSL 1.1.0.

NOTE: The patch itself does not depend on r/69725, but the ubuntu:16.04 test above does.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message