mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 69755: Moved flags and constants in MesosContainerLaunch into header.
Date Tue, 15 Jan 2019 22:27:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69755/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Repository: mesos


Description
-------

This removes the need to link 'src/containerizer/mesos/launch.cpp'
with the components (MesosContainerizer actor and Command Executor
binary) that use the 'mesos-containerizer' helper binary.


Diffs
-----

  src/launcher/executor.cpp f962e800f23d5582b1bc04a263253893492a5054 
  src/slave/containerizer/mesos/containerizer.cpp 5016f2e9f0651abcb0a5f364e8eace458f2edeae

  src/slave/containerizer/mesos/launch.hpp 0a6394d56321948ad760ac69c05456319a254842 
  src/slave/containerizer/mesos/launch.cpp 2f1c9e7a8748c9d7eab25bc8567ca68308e680f9 
  src/tests/containerizer/port_mapping_tests.cpp b511016fa7cd80d2ffee1747e5e463cc1b2d56bb



Diff: https://reviews.apache.org/r/69755/diff/1/


Testing
-------

cmake --build .


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message