mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69726: Fixed flakiness in MasterAPITest.OperationUpdatesUponOfferGone.
Date Mon, 14 Jan 2019 16:35:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69726/
-----------------------------------------------------------

(Updated Jan. 14, 2019, 4:35 p.m.)


Review request for mesos, Gastón Kleiman and Greg Mann.


Changes
-------

Updated review to fix the flakiness instead of disabling the test.


Summary (updated)
-----------------

Fixed flakiness in MasterAPITest.OperationUpdatesUponOfferGone.


Repository: mesos


Description (updated)
-------

It could happen that the first offer was sent before the allocator
had been updated with the resources from the resource provider.

To further increase reliability, stopped the clock during this test.


Diffs (updated)
-----

  src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849 


Diff: https://reviews.apache.org/r/69726/diff/2/

Changes: https://reviews.apache.org/r/69726/diff/1-2/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message