mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 69716: Updated `SlaveRecoveryTest.Reboot` to expect none pids.
Date Fri, 11 Jan 2019 14:52:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69716/#review211885
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Budnik


On Jan. 11, 2019, 8 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69716/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2019, 8 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-9501
>     https://issues.apache.org/jira/browse/MESOS-9501
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After agent host is rebooted, the recovered executor's forked pid and
> libprocess pid will be `NONE()` since we do not read them from agent's
> meta directory which are actually obsolete after reboot.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 0eb47e2bdf6a46fc21b59bb85b4b89181087ccd3 
> 
> 
> Diff: https://reviews.apache.org/r/69716/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message