mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69575: Send operation feedback when agent was marked as gone.
Date Thu, 27 Dec 2018 16:50:02 GMT


> On Dec. 21, 2018, 4:34 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 4885 (patched)
> > <https://reviews.apache.org/r/69575/diff/3/?file=2115287#file2115287line4885>
> >
> >     s/operationId.value()/operationId/
> 
> Benno Evers wrote:
>     Dropping this, as would result in a compilation error:
>     
>     ```
>     In file included from ../../src/tests/containerizer.hpp:51:
>     ../../src/tests/mesos.hpp:2027:10: error: no matching function for call to 'RESERVE'
>       return common::RESERVE<mesos::v1::Resources, mesos::v1::Offer>(
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     ../../src/tests/api_tests.cpp:4885:16: note: in instantiation of function template
specialization 'mesos::internal::tests::v1::RESERVE<mesos::v1::Resource &, mesos::v1::OperationID
&>' requested here
>               {v1::RESERVE(reserved, /*operationId.value()*/operationId)}));
>                    ^
>     ../../src/tests/mesos.hpp:1302:35: note: candidate function template not viable:
no known conversion from 'mesos::v1::OperationID' to 'const Option<std::string>' (aka
'const Option<basic_string<char> >') for 2nd argument
>     inline typename TOffer::Operation RESERVE(
>                                       ^
>     1 error generated.
>     ```

As it turns out, this was due to an upstream change to the signature of the `RESERVE()` function.
Fixed now.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69575/#review211485
-----------------------------------------------------------


On Dec. 27, 2018, 4:47 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69575/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2018, 4:47 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-8782
>     https://issues.apache.org/jira/browse/MESOS-8782
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an agent is marked as gone through the operator api,
> notify all frameworks with outstanding offer operations on
> that agent that these operations have been transitioned
> to `OPERATION_GONE_BY_OPERATOR`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316 
>   src/tests/api_tests.cpp b6064cd749e42e45c2b471c71e9769a41b59f726 
> 
> 
> Diff: https://reviews.apache.org/r/69575/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message