mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 69597: Remove outstanding operations when marking agents as gone.
Date Thu, 20 Dec 2018 13:56:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69597/#review211464
-----------------------------------------------------------




src/master/master.cpp
Lines 8885 (patched)
<https://reviews.apache.org/r/69597/#comment296622>

    After some discussion with @bbannier, I moved the removal into `markGone()` since we were
not sure that the master would be able to re-learn about the operations on the agent if it
will re-appear again later.
    
    This also raises a question about master failovers: Do we lose all information about operations
in this case, or is there some reconciliation mechanism for operations between master and
agents?


- Benno Evers


On Dec. 20, 2018, 1:46 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69597/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2018, 1:46 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Usually, offer operations are removed when the framework acknowledges
> a terminal operation status update.
> 
> However, currently only operations on registered agents can be
> acknowledged.
> 
> This commit explicitly deletes all outstanding offers from an agent
> when it is being marked gone.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e 
> 
> 
> Diff: https://reviews.apache.org/r/69597/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message