mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69591: Fixed allocator benchmark names to ensure proper filtering.
Date Wed, 19 Dec 2018 17:04:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69591/#review211437
-----------------------------------------------------------


Ship it!




Ship It!

- Till Toenshoff


On Dec. 19, 2018, 6:11 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69591/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2018, 6:11 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated names of allocator benchmarks in
> `tests/hierarchical_allocator_benchmarks.cpp` to ensure
> proper filtering.
> 
> The test filter `BENCHMARK_` is put at the beginning of the
> test name for consistency.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_benchmarks.cpp 822c2ef5f4fcdb1f4839ad5c2d6884c87cca3be2

> 
> 
> Diff: https://reviews.apache.org/r/69591/diff/1/
> 
> 
> Testing
> -------
> 
> Before the patch the test `MultiFrameworkAllocations` in the default test invocation
setting; after applying the patch, it does not run.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message