mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deepak Goel <deepak.go...@gmail.com>
Subject Re: Review Request 69590: Moves CNI root directory to a persistent location.
Date Wed, 19 Dec 2018 02:05:40 GMT


> On Dec. 19, 2018, 12:48 a.m., Till Toenshoff wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Lines 1307-1308 (original)
> > <https://reviews.apache.org/r/69590/diff/1/?file=2114813#file2114813line1309>
> >
> >     Are we assuming that this location was never meant for users?

Didn't understand your comment? Which location you are talking about?


- Deepak


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69590/#review211416
-----------------------------------------------------------


On Dec. 19, 2018, 2:03 a.m., Deepak Goel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69590/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2018, 2:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey Urbanovich.
> 
> 
> Bugs: MESOS-9492
>     https://issues.apache.org/jira/browse/MESOS-9492
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch moves the CNI root directory to mesos working directory
> so that the network related information persist across reboot which
> will allow cni isolator to do proper cleanup post reboot
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f19edce0671686bc2dccf5dc6d3abc40b925852e

>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 3b06fb101d03b32a3a148e2b79502413a7268d1e

>   src/slave/containerizer/mesos/isolators/network/cni/paths.cpp c1cb4f7d667159abbf87219cde30528a4a7b5283

>   src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 
>   src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 
>   src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24

> 
> 
> Diff: https://reviews.apache.org/r/69590/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deepak Goel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message