mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69578: Set up `Object.value` for `CREATE_DISK` and `DESTROY_DISK` authorization.
Date Tue, 18 Dec 2018 21:24:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69578/
-----------------------------------------------------------

(Updated Dec. 18, 2018, 9:24 p.m.)


Review request for mesos, Benjamin Bannier, Greg Mann, Jan Schlicht, and Till Toenshoff.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9486
    https://issues.apache.org/jira/browse/MESOS-9486


Repository: mesos


Description
-------

This patch sets up `Object.value` to the role of the resource for
authorization actions `CREATE_BLOCK_DISK`, `DESTROY_BLOCK_DISK`,
`CREATE_MOUNT_DISK` and `DESTROY_MOUNT_DISK` so an old-school authorizer
can rely on the field to perform authorization.


Diffs (updated)
-----

  src/master/master.cpp 3de0fd35cc815f4b5787ee2cb5e81f5059d7a47c 


Diff: https://reviews.apache.org/r/69578/diff/2/

Changes: https://reviews.apache.org/r/69578/diff/1-2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message