mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 69584: Relaxed matching criteria for benchmark filter.
Date Tue, 18 Dec 2018 14:41:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69584/
-----------------------------------------------------------

Review request for mesos and Meng Zhu.


Repository: mesos


Description
-------

Changed the benchmark filter to match all test names
containing the string `BENCHMARK`, as opposed to `BENCHMARK_`.

The latter filter would fail to match test names like
`HierarchicalAllocations_BENCHMARK.MultiFrameworkAllocations`,
contrary to the test authors assumptions.


Diffs
-----

  src/tests/environment.cpp 03f8f5971b1e91e62ecfbf965028e6f2388d2a7b 


Diff: https://reviews.apache.org/r/69584/diff/1/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message