mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 69543: Implemented recovery for volume gid manager.
Date Tue, 18 Dec 2018 08:12:46 GMT


> On Dec. 12, 2018, 2:38 a.m., Andrei Budnik wrote:
> > src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp
> > Lines 168 (patched)
> > <https://reviews.apache.org/r/69543/diff/1/?file=2112801#file2112801line168>
> >
> >     Consider adding `gidRanges` to the `message VolumeGidInfos` (rename it?), so
that the whole state will be stored in a single file. This requires storing original gid ranges
as a const class variable and modifying `persist()` method.

I updated the patches by not checkpointing the gid ranges, we should allow operators to specify
any gid ranges as they want.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69543/#review211200
-----------------------------------------------------------


On Dec. 18, 2018, 4:09 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69543/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2018, 4:09 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie
Yu.
> 
> 
> Bugs: MESOS-8810
>     https://issues.apache.org/jira/browse/MESOS-8810
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented recovery for volume gid manager.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 
>   src/Makefile.am 35500516e18ff251357b9e8d6bba894c44a9253b 
>   src/slave/containerizer/mesos/containerizer.cpp a5cf2da55c046c5c45e0c2ca3400f64de12de62b

>   src/slave/containerizer/mesos/volume_gid_manager/state.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/volume_gid_manager/state.proto PRE-CREATION 
>   src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.hpp PRE-CREATION

>   src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/69543/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message