mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 69398: Added validation for framework IDs.
Date Mon, 17 Dec 2018 08:43:33 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 17, 2018, 9:43 a.m.)

Review request for mesos, Benjamin Mahler and Meng Zhu.


Fixed handling of empty ID case to support current behavior.

Bugs: MESOS-9469

Repository: mesos


During scheduler subscription we currently cannot distinguish
self-assigned from master-assigned framework IDs, so we might allow
frameworks to subscribe even if the used framework ID was never assigned
by any master, see MESOS-1719.

This patch adds some validation of used framework IDs so that they can
e.g., savely be used in agents when persisting information.

We also clarify the API to call out that self-assigned framework IDs are
not explicitly supported.

Diffs (updated)

  include/mesos/mesos.proto 137df1f2083059dd06b2b15b50262c54ca3d2043 
  include/mesos/v1/mesos.proto f121709dff96453c5555b596fc66c8dd3d87b16e 
  src/master/validation.hpp 9af903970795a5c8c479d1984a580e41d91f6c91 
  src/master/validation.cpp 5fccc9f4fa6a81c08c5013b06c7b7795897a13a5 
  src/tests/master_validation_tests.cpp 3aa7b2a2dcaf054ad2a67c52462493c97b7178c4 




`make check`


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message