mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 69569: Added missing code to set resource provider and agent ids.
Date Fri, 14 Dec 2018 15:17:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69569/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Bugs: MESOS-9479
    https://issues.apache.org/jira/browse/MESOS-9479


Repository: mesos


Description
-------

The helper function to set up the message was set up to receive
arguments, but we missed implementing the code making use of the values.
This went undiscovered as previously only used a mock resource provider.


Diffs
-----

  src/common/protobuf_utils.cpp 583f0ab0dd874602bbd20731f1f32116a425ebc4 
  src/tests/master_tests.cpp 3bff7a13bb8013ef91b72c14ace23ee94bc190e9 
  src/tests/storage_local_resource_provider_tests.cpp 7887bd5ec300be3cc093886525d71b3e09bbf085



Diff: https://reviews.apache.org/r/69569/diff/1/


Testing
-------

* `make check`
* ran added test in repeatition, both with and without additional stress on the system


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message