mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 69541: Added volume gid manager.
Date Thu, 13 Dec 2018 12:36:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69541/#review211282
-----------------------------------------------------------




src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp
Lines 100 (patched)
<https://reviews.apache.org/r/69541/#comment296255>

    I have a small concern regarding unconditionally resetting permissions: what if a volume
had these flags enabled before we mounted them? Maybe we should add a TODO comment here for
restoring original permissions?


- Andrei Budnik


On Dec. 13, 2018, 11:46 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69541/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2018, 11:46 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie
Yu.
> 
> 
> Bugs: MESOS-8810
>     https://issues.apache.org/jira/browse/MESOS-8810
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added volume gid manager.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt bde070445b644e15d46c390d1c983caabaa1fec8 
>   src/Makefile.am 35500516e18ff251357b9e8d6bba894c44a9253b 
>   src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.hpp PRE-CREATION

>   src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/69541/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message