mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 69557: Removed redundant handling of empty framework IDs.
Date Wed, 12 Dec 2018 11:29:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69557/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9469
    https://issues.apache.org/jira/browse/MESOS-9469


Repository: mesos


Description
-------

We were previously treating empty framework IDs like unset framework
IDs and were maintaining dedicated handling for this case.

Since we now reject empty framework IDs this handling is not required
anymore and removed in this patch.


Diffs
-----

  src/master/master.cpp 3de0fd35cc815f4b5787ee2cb5e81f5059d7a47c 
  src/sched/sched.cpp e77a02951831a7e0c5d9a9068f8d014cb1478382 


Diff: https://reviews.apache.org/r/69557/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message