mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69397: Used high-level `FrameworkInfo` validation function in tests.
Date Tue, 11 Dec 2018 13:48:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69397/
-----------------------------------------------------------

(Updated Dec. 11, 2018, 2:48 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9469
    https://issues.apache.org/jira/browse/MESOS-9469


Repository: mesos


Description
-------

This patch replaces uses of `framework::validateRoles` with the more
high-level `framework::validate`. Since e.g., the master invokes
`validate` instead of directly invoking `validateRoles` this ensures
that our tests more closely match master behavior, and helps
preventing that we test code which is not invoked in reality.


Diffs (updated)
-----

  src/tests/master_validation_tests.cpp 3aa7b2a2dcaf054ad2a67c52462493c97b7178c4 


Diff: https://reviews.apache.org/r/69397/diff/2/

Changes: https://reviews.apache.org/r/69397/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message