mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.
Date Mon, 10 Dec 2018 18:42:36 GMT


> On Dec. 10, 2018, 5:06 p.m., James Peach wrote:
> > src/tests/containerizer/linux_filesystem_isolator_tests.cpp
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/69540/diff/1/?file=2112780#file2112780line137>
> >
> >     As a separate commit, can we factor out the flags set up from all these test
case?

The following patch in the patch chain factors out the flags.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69540/#review211146
-----------------------------------------------------------


On Dec. 10, 2018, 4:41 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69540/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2018, 4:41 p.m.)
> 
> 
> Review request for mesos, Jie Yu and James Peach.
> 
> 
> Bugs: MESOS-9462
>     https://issues.apache.org/jira/browse/MESOS-9462
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that pseudo devices like /dev/random are properly
> mounted in the container's root filesystem.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8

>   src/tests/containerizer/rootfs.cpp 83662fc2c2b9ea902b444bab9c2911df01ee11d5 
> 
> 
> Diff: https://reviews.apache.org/r/69540/diff/1/
> 
> 
> Testing
> -------
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message